Skip to content

Revert "Rollup merge of #154313 - mu001999-contrib:fix/154295, r=petrochenkov"#154477

Closed
Kobzol wants to merge 1 commit intorust-lang:mainfrom
Kobzol:revert-154313
Closed

Revert "Rollup merge of #154313 - mu001999-contrib:fix/154295, r=petrochenkov"#154477
Kobzol wants to merge 1 commit intorust-lang:mainfrom
Kobzol:revert-154313

Conversation

@Kobzol
Copy link
Copy Markdown
Member

@Kobzol Kobzol commented Mar 27, 2026

This reverts commit 85ddb8e, reversing
changes made to b5e4b4c.

Debugging the perf. hit from #154384.

@Kobzol
Revert "Rollup merge of rust-lang#154313 - mu001999-contrib:fix/15429…
db307c5 
…5, r=petrochenkov"

This reverts commit 85ddb8e, reversing
changes made to b5e4b4c.
@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 27, 2026
@Kobzol
Copy link
Copy Markdown
Member Author

Kobzol commented Mar 27, 2026

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

Sign in to view
rust-bors bot pushed a commit that referenced this pull request Mar 27, 2026
@bors
Auto merge of #154477 - Kobzol:revert-154313, r=<try>
198c5d7 
Revert "Rollup merge of #154313 - mu001999-contrib:fix/154295, r=petrochenkov"
@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Mar 27, 2026
@rust-bors

This comment has been minimized.

Sign in to view
@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors bot commented Mar 27, 2026

☀️ Try build successful (CI)
Build commit: 198c5d7 (198c5d761199695e091857478cba55cdd33d5f48, parent: fda6d37bb88ee12fd50fa54d15859f1f91b74f55)

@rust-timer

This comment has been minimized.

Sign in to view
@rust-timer
Copy link
Copy Markdown
Collaborator

rust-timer commented Mar 27, 2026

Finished benchmarking commit (198c5d7): comparison URL.

Overall result: ✅ improvements - no action needed

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -0.3% [-0.4%, -0.3%] 5
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results (primary 0.1%, secondary 1.8%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 2.4% [2.4%, 2.4%] 1
Regressions ❌
(secondary)		 1.8% [1.7%, 1.9%] 2
Improvements ✅
(primary)		 -2.1% [-2.1%, -2.1%] 1
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 0.1% [-2.1%, 2.4%] 2

Cycles

Results (secondary -4.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -4.1% [-6.0%, -2.2%] 2
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 485.109s -> 483.832s (-0.26%)
Artifact size: 395.05 MiB -> 395.04 MiB (-0.00%)

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Mar 27, 2026
@Kobzol
Copy link
Copy Markdown
Member Author

Kobzol commented Mar 27, 2026

The perf. effect here doesn't look very interesting, closing.

@Kobzol Kobzol closed this Mar 27, 2026
@rustbot rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Mar 27, 2026
@Kobzol Kobzol deleted the revert-154313 branch March 30, 2026 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Kobzol @rust-timer @rustbot